arcus-azure / arcus.eventgrid

Azure Event Grid development in a breeze
https://eventgrid.arcus-azure.net/
MIT License
17 stars 6 forks source link

Feature - initial publish raw CloudEvents #119

Closed stijnmoreels closed 4 years ago

stijnmoreels commented 4 years ago

Relates to #117 Closes #123

arcus-automation commented 4 years ago

A new preview package for Arcus.EventGrid.All is available on MyGet.

You can pull it locally via the CLI:

PM> Install-Package Arcus.EventGrid.All -Version 20200225.0.0-PR-119 -Source https://www.myget.org/F/arcus/api/v3/index.json
stijnmoreels commented 4 years ago

Hmm, question: when we have to publish raw events as CloudEvents, what should the required source property be in the event?

stijnmoreels commented 4 years ago

I changed the publisher to publish all the kind of events as CloudEvents since that's the only correct way I guess. We should I think wait for #112 to be completed before we can publish custom events as cloud events .

arcus-automation commented 4 years ago

A new preview package for Arcus.EventGrid.All is available on MyGet.

You can pull it locally via the CLI:

PM> Install-Package Arcus.EventGrid.All -Version 20200228.0.0-PR-119 -Source https://www.myget.org/F/arcus/api/v3/index.json
stijnmoreels commented 4 years ago

LGTM but we'll need CloudEvent tests as well, would you mind adding some please?e

Yes, I'm gonna need some help with that. Infrastructure-stuff and all. I even can't get the existing integration tests to work locally 😭 .

tomkerkhove commented 4 years ago

What do you need and what is it that you can't create?

arcus-automation commented 4 years ago

A new preview package for Arcus.EventGrid.All is available on MyGet.

You can pull it locally via the CLI:

PM> Install-Package Arcus.EventGrid.All -Version 20200302.0.0-PR-119 -Source https://www.myget.org/F/arcus/api/v3/index.json
stijnmoreels commented 4 years ago

What do you need and what is it that you can't create?

I need a CloudEvent infrastructure like for the EventGrid events. But I can't to seem to alter the custom deployment template to make sure the input schema is CloudEvent instead of EventGrid events.

arcus-automation commented 4 years ago

A new preview package for Arcus.EventGrid.All is available on MyGet.

You can pull it locally via the CLI:

PM> Install-Package Arcus.EventGrid.All -Version 20200303.0.0-PR-119 -Source https://www.myget.org/F/arcus/api/v3/index.json
tomkerkhove commented 4 years ago

We'll need both but feel free to manually just create one in your subscription and if everything is up and running I can do the required part in the Arcus subscription

stijnmoreels commented 4 years ago

We'll need both but feel free to manually just create one in your subscription and if everything is up and running I can do the required part in the Arcus subscription

I know, but how do you change the deployment template to use the CloudEvent as input schema?

tomkerkhove commented 4 years ago

Just create it via the portal :)

Alternatively you can just check https://github.com/arcus-azure/arcus.eventgrid/pull/116

stijnmoreels commented 4 years ago

Ok, I added some integration tests for the CloudEvents and I added also some appsettings keys to the devops lirbary so they work here. It still uses resources on my local subscription but that's fine I guess until #115 is resolved.

arcus-automation commented 4 years ago

A new preview package for Arcus.EventGrid.All is available on MyGet.

You can pull it locally via the CLI:

PM> Install-Package Arcus.EventGrid.All -Version 20200304.0.0-PR-119 -Source https://www.myget.org/F/arcus/api/v3/index.json
tomkerkhove commented 4 years ago

It depends on the current setup - So you now use an event grid topic with Event Grid schema and one with CloudEvents, right?

115 is only for setting up the testing infrastructure for using it integration tests, not specific for our testing.

stijnmoreels commented 4 years ago

It depends on the current setup - So you now use an event grid topic with Event Grid schema and one with CloudEvents, right?

Yes, right. Both on my subscription though. I'll leave it up to you to update the stuff with resources on the Arcus resource group (with the right names and all).

stijnmoreels commented 4 years ago

So... @tomkerkhove , only the ARM templates and the updates in the Azure resource groups are needed to delegate the tests against the R&D subscription. Definitely other PR I guess, so this isn't blocked.

But besides that, everything is done?

tomkerkhove commented 4 years ago

Feel free to create an issue for the Azure changes and assign it to me