search

arcus-azure / arcus.eventgrid

Azure Event Grid development in a breeze
https://eventgrid.arcus-azure.net/
MIT License
17 stars 6 forks source link

Does our validation handshake support CloudEvents #138

Closed tomkerkhove closed 2 years ago

tomkerkhove commented 4 years ago

Does our validation handshake support CloudEvents format?

tomkerkhove commented 4 years ago

I think it does since we use an abstraction but want to verify this.

stijnmoreels commented 4 years ago

What do you refer to on 'validation handshake'?

tomkerkhove commented 4 years ago

This - https://eventgrid.arcus-azure.net/features/endpoint-validation

stijnmoreels commented 4 years ago

Hmm, not sure, haven't worked with that and not sure how it relates to CloudEvents. Not even sure if this is tested correctly?

stijnmoreels commented 4 years ago

Hmm, actually, the validation here is specific an Azure subscription validation model that is required, no CloudEvents. So no sure if this is something that can be done here.

tomkerkhove commented 4 years ago

Can we investigate if we cna support CloudEvents for this as well?

stijnmoreels commented 4 years ago

This seems like it can be done: https://docs.microsoft.com/en-us/azure/event-grid/cloudevents-schema#endpoint-validation-with-cloudevents-v10 https://github.com/cloudevents/spec/blob/v1.0/http-webhook.md#4-abuse-protection

So it seems like it uses HTTP OPTIONS for this.

tomkerkhove commented 4 years ago

Nope, that just defines the spec - We'll need to see what the changes are for us to support this.

stijnmoreels commented 3 years ago

I think we can close since this was done in #182 , right?

tomkerkhove commented 2 years ago

Yes!