arcus-azure / arcus.eventgrid

Azure Event Grid development in a breeze
https://eventgrid.arcus-azure.net/
MIT License
17 stars 6 forks source link

feat: add Event Grid telemetry dependency tracking #159

Closed stijnmoreels closed 3 years ago

stijnmoreels commented 3 years ago

Adds our dependency telemetry tracking on the Azure Event Grid publisher instance.

Closes #156

stijnmoreels commented 3 years ago

The opt-in functionality is here implicit by passing the ILogger instance. It seemed unnecessary to add an additional boolean for this, no? Otherwise, the dependency telemetry can be opt-out with our telemetry type filter.

tomkerkhove commented 3 years ago

The opt-in functionality is here implicit by passing the ILogger instance. It seemed unnecessary to add an additional boolean for this, no? Otherwise, the dependency telemetry can be opt-out with our telemetry type filter.

I can see what you mean, but maybe it's best to make it explicit, no? End-users don't know how the ILogger is being used?

stijnmoreels commented 3 years ago

The opt-in functionality is here implicit by passing the ILogger instance. It seemed unnecessary to add an additional boolean for this, no? Otherwise, the dependency telemetry can be opt-out with our telemetry type filter.

I can see what you mean, but maybe it's best to make it explicit, no? End-users don't know how the ILogger is being used?

Yes, I see your point. Thanks for reminding me! I've changed that so it takes in a set of options.