search

arcus-azure / arcus.eventgrid

Azure Event Grid development in a breeze
https://eventgrid.arcus-azure.net/
MIT License
17 stars 6 forks source link

chore: support net8.0 preview #312

Closed stijnmoreels closed 5 months ago

stijnmoreels commented 9 months ago

Add .NET 8 preview support with previously preview-supported Arcus libraries Observability & Security.

netlify[bot] commented 9 months ago

Deploy Preview for arcus-eventgrid canceled.

Name Link
Latest commit ad4ec0446083e87fb7c4de92c2e0e644bfbf54eb
Latest deploy log https://app.netlify.com/sites/arcus-eventgrid/deploys/6524e25575b58d0007423433
codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (3d2e7ec) 87.44% compared to head (ad4ec04) 87.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #312 +/- ## ========================================== - Coverage 87.44% 87.31% -0.14% ========================================== Files 15 15 Lines 733 733 Branches 50 52 +2 ========================================== - Hits 641 640 -1 Misses 74 74 - Partials 18 19 +1 ``` | [Files](https://app.codecov.io/gh/arcus-azure/arcus.eventgrid/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arcus-azure) | Coverage Ξ” | | |---|---|---| | [....Core/Validation/EventGridSubscriptionValidator.cs](https://app.codecov.io/gh/arcus-azure/arcus.eventgrid/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arcus-azure#diff-c3JjL0FyY3VzLkV2ZW50R3JpZC5TZWN1cml0eS5Db3JlL1ZhbGlkYXRpb24vRXZlbnRHcmlkU3Vic2NyaXB0aW9uVmFsaWRhdG9yLmNz) | `100.00% <100.00%> (ΓΈ)` | | | [....Testing/Infrastructure/Hosts/EventConsumerHost.cs](https://app.codecov.io/gh/arcus-azure/arcus.eventgrid/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arcus-azure#diff-c3JjL0FyY3VzLkV2ZW50R3JpZC5UZXN0aW5nL0luZnJhc3RydWN0dXJlL0hvc3RzL0V2ZW50Q29uc3VtZXJIb3N0LmNz) | `88.74% <100.00%> (-0.67%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fgheysels commented 8 months ago

Should we resolve the warnings that are being displayed regarding the obsolete methods / types that are being used ?

stijnmoreels commented 8 months ago

Should we resolve the warnings that are being displayed regarding the obsolete methods / types that are being used ?

Those are there because we're testing obsolete functionality, so these could in fact be ignored in those test files (we could add #pragma to those). Not sure, though, if this PR is the right place to do it.

fgheysels commented 7 months ago

Should we resolve the warnings that are being displayed regarding the obsolete methods / types that are being used ?

Those are there because we're testing obsolete functionality, so these could in fact be ignored in those test files (we could add #pragma to those). Not sure, though, if this PR is the right place to do it.

Ok. Can you create an issue for removing the obsolete functionality ?

stijnmoreels commented 7 months ago

Ok. Can you create an issue for removing the obsolete functionality ?

Normally, when something is marked 'deprecated', there is an issue created for it, assigned to the next major, so in this case, we already have several of these issues: https://github.com/arcus-azure/arcus.eventgrid/issues?q=is%3Aissue+is%3Aopen+remove