arcus-azure / arcus.messaging

Messaging with Microsoft Azure in a breeze.
https://messaging.arcus-azure.net
MIT License
20 stars 11 forks source link

chore: use built-in service bus client in message pump (🚧) #417

Open stijnmoreels opened 1 year ago

stijnmoreels commented 1 year ago

Use the default registration of the ServiceBusClient to use in the Azure Service Bus message pump. This is somewhat related to the #411 to get a ServiceBusSender in a more easier way; but is also a performance improvement as the host will now handle the connection for us instead of the message pump (which was re-creating the client in some cases of restart).

Relates to #411

netlify[bot] commented 1 year ago

Deploy Preview for arcus-messaging canceled.

Name Link
Latest commit ac98324237799eddbf202e762249865019262f51
Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/651679e48bb12f00081000e1
stijnmoreels commented 1 year ago

Why still in draft ?

Bc I'm still working on it, as the tests were failing and it was late so I hadn't time to look into them. 😄 But I wanted to push my changes nonetheless so I would be reminded that I still need to work on this. So, thx! 😉

fgheysels commented 3 months ago

Is this PR still relevant ?