arcus-azure / arcus.scripting

Scripting with Microsoft Azure in a breeze.
https://scripting.arcus-azure.net/
MIT License
9 stars 11 forks source link

feat: added optional DaysToKeep parameter to Save-AzDevOpsBuild #383

Closed pim-simons closed 1 year ago

pim-simons commented 1 year ago

Added an optional DaysToKeep parameter where you can specify how many days to pipeline run must be saved. To do this I had to move to api version 7.0, so needed some more changes that I initially expected (also in the tests).

Closes https://github.com/arcus-azure/arcus.scripting/issues/382

netlify[bot] commented 1 year ago

Deploy Preview for arcus-scripting canceled.

Name Link
Latest commit c7fccd33eda2bef3e670da7c1c35283d7a71b757
Latest deploy log https://app.netlify.com/sites/arcus-scripting/deploys/6450f9974c712f0008dd663e
pim-simons commented 1 year ago

Pending review, we check a bit more next week. Looks already very good! A real practical improvement. Super. 😄

Wow you are fast, the integrations tests were not even done yet 😮

stijnmoreels commented 1 year ago

Pending review, we check a bit more next week. Looks already very good! A real practical improvement. Super. 😄

Wow you are fast, the integrations tests were not even done yet 😮

Maybe if we convert to universal time, we will get a more stable assertion.

.ToUniversalTime().ToString("yyyy-MM-dd")

Was something we did with the other tests as well.