search

arcus-azure / arcus.testing

Reusable testing components used during Arcus testing.
https://testing.arcus-azure.net/
MIT License
5 stars 2 forks source link

fix: equalization on JSON `null` node #178

Closed stijnmoreels closed 1 month ago

stijnmoreels commented 2 months ago

For some obscure reason, Microsoft decided that the JsonNode representing a JSON null value, should be represented with a C# null value. Because of this, one looses context and also has to deal with null checks everywhere. Bad design decision of Microsoft, but something that we forgot to handle in special cases.

Fixes that here.

netlify[bot] commented 2 months ago

Deploy Preview for arcus-testing canceled.

Name Link
Latest commit 201554bce9f6281369ca8a07bd21183e8ab38740
Latest deploy log https://app.netlify.com/sites/arcus-testing/deploys/66c331bdc4f68000083e8276
arcus-automation commented 2 months ago

🧪 Code coverage summary

Metric Value
Line coverage 🟢 89.1%
Branch coverage 🔴 78%

😟 Your code coverage is not fully reaching 80 % yet. Please inspect the report to find possible improvements and before you know it, your code coverage will reach the stars! 🚀

stijnmoreels commented 1 month ago

Implicitly done via #176