search

arcus / Arcus_Labs_Orientation

Orientation for new Arcus Scientific Labs users
https://liascript.github.io/course/?https://raw.githubusercontent.com/arcus/Arcus_Labs_Orientation/main/arcus_orientation.md
1 stars 1 forks source link

Replace warning about viewing materials making you ineligible to participate in DART #30

Closed rosemm closed 1 year ago

rosemm commented 1 year ago

I replaced the warnings in each of the "new to..." files. We've changed the exclusion criteria for the DART research program, so folks who have seen our materials will no longer be ineligible to participate. I switched it from a warning box to "cool-fact" (icon is a brain), and removed the "don't look at these modules!" language and replaced with a carrot to encourage interested folks to click the links above ("If you meet our research criteria and decide to enroll as a study participant, you'll receive additional data science learning support, including a customized curriculum of materials and the peership and support of a community of learners like you.")

franzenr commented 1 year ago

bullets don't seem to be working on my end. I feel like the whitespace problems frequently go back and forth, and I'm not sure where things land currently, but I'm wondering if that could be it?

rosemm commented 1 year ago

Hmm I can't replicate the bullet issue (e.g. https://liascript.github.io/course/?https://raw.githubusercontent.com/arcus/Arcus_Labs_Orientation/rose_fix/new_to_data_science.md renders fine for me). Is there a particular page where you were noticing that? @franzenr

franzenr commented 1 year ago

Hmm, I'm having that issue even on that exact link... maybe it's a caching thing for me? I'll see what happens in private browser, etc

screenshot demonstrating highlight box issue where bullets just appear as asterisks and all appear as if on one continuous line.
franzenr commented 1 year ago

Updated my browser, tried incognito, and tried using firefox -- the issue persists for me under all of these conditions

rosemm commented 1 year ago

Ah yes, I see it now too. I think I just fixed it --- try again?

franzenr commented 1 year ago

works for me now!! 🙌

Although I just realized that in the new box, the links aren't descriptive links, it's just written out, which is not ideal for anyone using a screenreader. So I'm going to hop in and make those changes now since we're already making edits!

franzenr commented 1 year ago

Got through all of the "new to" documents, but there's also lots of descriptive link text and alt text issues in the orientation doc -- Don't have the full bandwidth to tackle it right now, so I'm going to file it away as an issue for now. @rosemm