arcusmaximus / KirikiriTools

Tools for the Kirikiri visual novel engine
MIT License
291 stars 29 forks source link

Encoding/character problems using Xp3Pack. #16

Open Some1isd opened 1 year ago

Some1isd commented 1 year ago

I extracted game files using GARbro and used xp3pack to make a patch file for version.dll. When the only files were .scn files made with VNTextPatch there were no problems. However, when inserting .tjs files, even unmodified ones, into the patch, it would cause the game to not launch, giving "Illegal character" errors. The character listed as being illegal is not actually in the file, though (examples: '\x19' or '\x1e')

When i made the exact same patch using the "Create Archive" utility in GARbro, there was no such problem, and I confirmed that the .tjs file changes were actually applied. The encryption type GARbro lists is CxEncryption. The "Storage Media" reported by version.dll are cxfilter and psb. The error dialog appears after version.dll prints "Creating unencrypted XP3 stream for file.tjs" twice for the same file.

arcusmaximus commented 1 year ago

Please let me know which game this is for and which .tjs file you're trying to replace. I can't investigate based on error messages alone.

Some1isd commented 1 year ago

Game is https://vndb.org/v16089 I was mistaken that the scn files work. There are no visible problems at first but the first scene of the game will always crash at a certain point when the scn is in the patch made with Xp3Pack. If the patch is made with GARbro create archive there is no crash there.