arcusmaximus / VNTranslationTools

Tools for translating visual novels
MIT License
295 stars 44 forks source link

Request: TmrAdvSystem #46

Closed xenei closed 2 years ago

xenei commented 2 years ago

Hello, Is it possible to add support for TmrAdvSystem game-engine? the archive format is .pac and script files are format-less, though Garbro shows them as .srp and .var for system files; which also has some important text for the game, this game engine is mostly used by Lune titles - https://vndb.org/p490 - Here's a reference - Link The attached link for the reference can only extract but can't repack to .srp and .var EDIT: Here's an sample of the script files and system files - garbro.zip Thank you.

xenei commented 2 years ago

I saw that you added json output rather than txt, but if possible can you make the Json output be more like this - asd Where there is both Original JP line and translated line for future QC and editing. Here's a python script reference that makes json outputs like that - Link Only if possible, thank you.

AtomCrafty commented 2 years ago

Using the Japanese text as dictionary keys sounds like a recipe for desaster... It will fail as soon as any text appears twice and also the order is not necessarily preserved.

arcusmaximus commented 2 years ago

Support implemented. I didn't test it ingame, so let me know if everything works (line breaks, choice screens...)

As @AtomCrafty wrote, using messages as dictionary keys is a bad idea because there will always be cases where a (proper) translator wants to have different translations for lines that are identical in the original.

xenei commented 2 years ago

Everything seems to be working, choices, text etc, but word-wrap is not working The Line-break code should be \n , I tried both Mono and proportional, but none seems to make any difference Choices is also fine - image

arcusmaximus commented 2 years ago

Wordwrapping added (monospace), please try again.

xenei commented 2 years ago

Unfortunately, it still doesn't seem to be working, decreasing or increasing Monospace char value doesn't make any difference Though manually adding \\n to script seems fine

arcusmaximus commented 2 years ago

Forgot to also apply the wordwrapping to narration lines (only did it for dialogue at first)... Should work now.

xenei commented 2 years ago

It's working, thank you very much