Closed sethwoodworth closed 6 years ago
I'm not really a neovim contributer, but I do want to get Athame working on neovim as well.
I think right now, the only problem is that neovim doesn't support remote-expr, but I'm sure there's some neovim way to do similar using msg-pack or whatever, I just haven't looked into it yet.
relevant neovim issue: neovim/neovim#1750
as of now, https://github.com/mhinz/neovim-remote is a "temporary solution"
Thanks for the link! I tried neovim-remote a while back but it was a) more of a way to make neovim more like --remote than a full backwards compatible impl that would be needed here and b) very buggy. These might no longer be the case, so if anybody can get Athame to work with neovim-remote, let me know and I'll add instructions to the readme.
I have a plan for adding support for the new vim jobs in athame 0.9 or 0.10 and if neovim jobs are similar enough (I think they are), I'll add native neovim support too while I'm at it. This will hopefully be by the end of the year.
Has there been any progress on this issue? Cheers.
The unstable 1.0 branch of athame supports the new v8 style async that is very similar to neovim. If there aren't any major hurdles, I'll probably add neovim support in athame 1.1 (hopefully within the next month or two, but it depends how much free time I have)
On Mon, Sep 25, 2017 at 6:01 AM Steven Noble notifications@github.com wrote:
Has there been any progress on this issue? Cheers.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ardagnir/athame/issues/12#issuecomment-331784635, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUkPqFZCLhd15lHuPRG0xdsnhNR0Aa0ks5sl0HFgaJpZM4D-K4E .
I don't normally read C at all, but I'm thinking that to support Neovim, you just need a switch in athame/athame_util.h
that changes vim
to nvr
and a prompt to check that the Neovim user has installed Neovim-Remote.
Athame already supports different binaries using the vimbin flag in the setup script. The problem is that Neovim-Remote, last I checked, is both very buggy, and behaves differently than normal vim's remote. It'll be easier to just use Neovim jobs than Neovim-Remote, but there's nothing stopping you from trying.
On Tue, Nov 21, 2017 at 9:43 PM Steven Noble notifications@github.com wrote:
I don't normally read C at all, but I'm thinking that to support Neovim, you just need a switch in athame/athame_util.h that changes vim to nvr and a prompt to check that the Neovim user has installed Neovim-Remote.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ardagnir/athame/issues/12#issuecomment-346226624, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUkPj69dQBTB1TJwHM5lZU3J6xlAxKVks5s44pBgaJpZM4D-K4E .
Any progress regarding neovim support?
There's basic neovim support in the neovim branch. It will get rolled out to master in the 1.1 release.
I see that you have contributed to neovim. Have you considered using Neovim for this purpose rather than stock vim?