search

ardalis / GuardClauses

A simple package with guard clause extensions.
MIT License
3.06k stars 270 forks source link

Upgrade to dotnet 7.0 #282

Closed amal-stack closed 1 year ago

ardalis commented 1 year ago

If we update to net7 that will make it tough for older projects to use. Is there anything that requires net7?

amal-stack commented 1 year ago

@ardalis I tried upgrading because I noticed the CI builds have been failing lately due to an error in the ReferenceAssemblyAnnotator library: Build Errors It is an open issue in the library that it breaks on projects with multiple framework targets.
In my fork, the build succeeded when I upgraded to .NET 7. (This might also be due to the fact that build.yml uses dotnet 7 to build the project, not quite sure): Commits Notice the top two commits where the build started failing when I reverted to .NET 6.

ardalis commented 1 year ago

Weird, thanks. Looking into it.

ardalis commented 1 year ago

Since we still have netstandard targeting hopefully this should be fine.