search

ardalis / Result

A result abstraction that can be mapped to HTTP response codes if needed.
MIT License
866 stars 107 forks source link

Updated github actions to remove deprecation warnings #130

Closed thomas-mullaly closed 1 year ago

thomas-mullaly commented 1 year ago

I noticed that there are deprecation warnings with some of the action workflows. Additionally, the action that's being used to publish the nuget packages is no longer maintained. This is a problem because that action uses the set-output command, which GitHub has deprecated and will be completely removing at the end of May.

These upgrades should clear warnings around a deprecated nodejs version and issuse with using set-output.

For the nuget package publishing, I haven't really been able to test the push command but I did try to replicate what the old action was doing to publish packages.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result.SampleWeb 62% 50% 33 ➖
Ardalis.Result 32% 18% 64 ❌
Ardalis.Result.AspNetCore 65% 70% 126 ➖
Ardalis.Result.Sample.Core 25% 33% 50 ❌
Ardalis.Result.FluentValidation 0% 0% 6 ❌
Summary 47% (357 / 766) 56% (82 / 146) 279 ❌
ardalis commented 1 year ago

Thanks!