ardalis / Result

A result abstraction that can be mapped to HTTP response codes if needed.
MIT License
866 stars 107 forks source link

Fix TargetFrameworks #155

Closed DorianGreen closed 12 months ago

DorianGreen commented 12 months ago

This PR normalizes the TargetFrameworks in all the projects. Addresses #148

notes: some of the referenced packages require per target version overrides in order to compile. caution should be exercised when updating dependencies. it is best to manually update the proj/props files.

This PR also adds some GlobalPackageReferences. PolySharp can be used to access modern language polyfills, and is a dev only reference SourceLink will help clients with debugging.

DorianGreen commented 12 months ago

net4.7.1 tests are failing. for details on the issue see: https://stackoverflow.com/questions/47155559/could-not-load-file-or-assembly-microsoft-visualstudio-testplatform-objectmodel

At this point we can decide to try and fix the build or exclude net4.7.1 as a Test target. note that all the tests pass locally.

github-actions[bot] commented 12 months ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result.Sample.Core 18% 18% 63
Ardalis.Result.FluentValidation 86% 50% 6
Ardalis.Result 20% 0% 82
Summary 23% (94 / 416) 17% (9 / 54) 151
DorianGreen commented 12 months ago

Tests pass by explicitly adding the failing package, and adding all missing binding redirects into app.config of unit tests.

ardalis commented 12 months ago

Looks good, thanks!