Fix 181 - Githubissues

ardalis / Result

A result abstraction that can be mapped to HTTP response codes if needed.

MIT License

866 stars 107 forks source link

Fix 181 #182

Closed ardalis closed 5 months ago

ardalis commented 5 months ago

Fixes #181 Make ErrorList correlationId optional Allow Result.Error to take a single error message string

github-actions[bot] commented 5 months ago

Package	Line Rate	Branch Rate	Complexity	Health
Ardalis.Result	82%	95%	109	✔
Summary	82% (193 / 234)	95% (36 / 38)	109	✔

lloydkevin commented 3 weeks ago

Questions:

Was the intent to replace the method taking params string[] errorMessages or should it have remain and delegate to the new method?
Is a similar change needed on all the others? (NotFound, Unauthorized, etc.)?

ardalis commented 1 week ago

Probably both methods should still exist (single string as well as string array) and yeah probably across the board. If you have time do you want to create an issue for this and perhaps a PR?