search

ardalis / Result

A result abstraction that can be mapped to HTTP response codes if needed.
MIT License
847 stars 100 forks source link

Fixes #196 #197

Closed wtygibbs closed 1 month ago

wtygibbs commented 1 month ago

Fixes #196

An assumption I made for setting the location header is that we could allow users to only define a relative location by deriving the base URL from the controller that is calling .ToActionResult on the Created result.

Is this OK or do you think we ought to allow them to specify the entire URL, or both?

Sorry If I've overlooked anything regarding this, it is my first PR.

wtygibbs commented 1 month ago

Although it worked for my use-case, I don't like my use of dynamic to check for the Location property and there were other things I missed. I'll open a new PR with a better solution.