search

ardalis / Result

A result abstraction that can be mapped to HTTP response codes if needed.
MIT License
881 stars 107 forks source link

Add ValidationError constructor that accepts identifier and error message #208

Open gordysc opened 2 months ago

gordysc commented 2 months ago

Aloha!

There appears to be a good amount of overlap between FluentValidation's ValidationFailure and this project's ValidationError class. One slight difference is the ValidationFailure class has a constructor that accepts a property name and error message. Thoughts on adding something similar to the ValidationError class in this repository? I'm not suggesting modifying any of the current constructors, but simply adding one that accepts these two values:

public ValidationError(string identifier, string errorMessage)
{
    this.Identifier = identifier;
    this.ErrorMessage = errorMessage;
}

This would simplify the following code:

// Current state
new ValidationError(nameof(Model.Name), "Name is required.", "", ValidationSeverity.Error);
// Proposed enhancement
new ValidationError(nameof(Model.Name), "Name is required.")

If you approve of the above enhancement I'd be happy to open a PR! Cheers!

ardalis commented 2 months ago

No objection - PR would be welcome. thanks!