Closed pauldbentley closed 4 years ago
It’s a two step process. You have to update and publish the base package then update to use it in the other one and deploy it. I’ll sort that part out. Thanks!
This is a breaking change so at a minimum should have an appropriate major version bump since there has already been getting on for 200 downloads.
Maybe making it a param array or adding an overload to help with compatibility
Good point; I'll get the versions sorted out as well (with version bumps).
This is also something of interest in the context of what a validation result means. Something I have commented further on here: https://github.com/ardalis/Result/issues/16#issuecomment-630255263
Thanks @pauldbentley - we ended up incorporating a lot of this into a couple of other recent PRs. Cheers!
Thanks @ardalis - it's great to see this package developing.
FYI - I've been using my own package while this one evolves, my ultimate aim is to use your package.
I've got a few differences in-case they were useful:
Result
, this allows for results that don't return a value.Result
which helps with CA1000.This makes the code:
return Result<IEnumerable<WeatherForecast>>.NotFound();
Become:
return Result.NotFound<IEnumerable<WeatherForecast>>();
Error()
which takes an object problem
I find this useful for returning a ProblemDetails
from a WebAPI.OkResult
, and ErrorResult
to help building results.
Hi Steve,
This changes ValidationErrors to allow mutiple errors for the same key.
I wasn't sure how to update the Nuget links, so I have commented out the package references and just added in a project references. I presume this is something you can check and change?
Thanks
Paul