Feature Request: Deletion of entities via specification

[thorstenalpers]

Hi, Ardalis Specification is a really great project that I use extensively as Nuget. I have an additional feature request. I have implemented in my own EfRepository, but would like to see in your project. It is about deleting entities per specification.

The existing way is to list entities and then delete them.

 public abstract class RepositoryBase<T> : IReadRepository<T> where T : class
{
...
   public virtual async Task DeleteRangeAsync(ISpecification<T> specification, CancellationToken cancellationToken = default)
    {
        var query = ApplySpecification(specification);
        _dbContext.Set<T>().RemoveRange(query);
        await SaveChangesAsync(cancellationToken);
    }
...
}

I could also create a PR with unittests.

[fiseni]

Hi @thorstenalpers

Yea we may add it. Do you want to give it a try? @ardalis do you have any objections?

[thorstenalpers]

Yeah, I would try it out, I could also create a PR with UnitTests.

[ardalis]

No objections, go for it @thorstenalpers !

[thorstenalpers]

@ardalis I have created a fork and created a branch "feature/delete-range-by-spec" and created a PR in my repository.

PR: https://github.com/ardalis/Specification/pull/369

I have implemented it for both EF6 and EfCore. EF6 doesn't delete referenced entities automatically, therefore I added some specifications for entities without referenced entities.

If you want some more tests or explanations then feel free to contact me.

[fiseni]

Resolved by PR #369