search

ardanlabs / service

Starter-kit for writing services in Go using Kubernetes.
https://www.ardanlabs.com
Apache License 2.0
3.4k stars 613 forks source link

Add auth header to make curl-create target #353

Closed levikobi closed 3 months ago

levikobi commented 3 months ago

This request will not work without the authorization header

ardan-bkennedy commented 3 months ago

If we are going to do this, are there other commands that can take advantage of this readability?

levikobi commented 3 months ago

I guess otel-test could be reformated the same way. Let me know if you want me to switch it up too, I'll update the commit.

ardan-bkennedy commented 3 months ago

Consistency is everything. So let's do this to anything that goes beyond 80 columns

ardan-bkennedy commented 3 months ago

I will accept this and fix the other calls.

levikobi commented 3 months ago

Sorry for the delay. I planned on pushing it later If you want, I have pushed this for your reference https://github.com/levikobi/service/commit/0a0ed7bfbb23e4b05632083cdaaddb5c9b8ef943

ardan-bkennedy commented 3 months ago

It's all good. I accepted the PR and cleaned up what I wanted. This was a nice change.