search

ardanlabs / service

Starter-kit for writing services in Go using Kubernetes.
https://www.ardanlabs.com
Apache License 2.0
3.4k stars 612 forks source link

Wrong environment variable name for migrate and seed sections of makefile #356

Closed cadabrum closed 2 months ago

cadabrum commented 2 months ago

The sections below use the SALES_DB_HOST environment variable

migrate:
    export SALES_DB_HOST=localhost; go run app/tooling/sales-admin/main.go migrate

seed: migrate
    export SALES_DB_HOST=localhost; go run app/tooling/sales-admin/main.go seed

The commands fail with an error:

export SALES_DB_HOST=localhost; go run app/tooling/sales-admin/main.go migrate
msg migrating database: migrate database: status check database: context deadline exceeded
exit status 1
make: *** [migrate] Error 1

Сorrect variable name SALES_DB_HOST_PORT?

ardan-bkennedy commented 2 months ago

Yea you are right. I will fix this now. Thanks!