Refactor: Improve JSON formatting in Docker inspect template.

ardanlabs / service

Starter-kit for writing services in Go using Kubernetes.

https://www.ardanlabs.com

Apache License 2.0

3.59k stars 649 forks source link

Closed mobamoh closed 2 months ago

mobamoh commented 2 months ago

Replace manual string manipulation with in-template formatting for cleaner, more efficient code.

ardan-bkennedy commented 2 months ago

Have you tested this with IPv6 on so docker returns 2 IP addresses and not just 1?

ardan-bkennedy commented 2 months ago

Also, I need you to add yourself to the contributors file please.

mobamoh commented 2 months ago

Hi Bill, Yes I've tested. Attached the screenshots.

mobamoh commented 2 months ago

Also, I need you to add yourself to the contributors file please.

Sure! where can I find that?

ardan-bkennedy commented 2 months ago

It's at the root of the project. This change is awesome!

ardan-bkennedy commented 2 months ago

Can you please keep the CONTRIBUTORS file is alphabetical order.

mobamoh commented 2 months ago

file is alphabetical order.

Done ✅