search

ardaogulcan / react-native-keyboard-accessory

A React Native Keyboard Accessory (View, Navigation) Component. Sticky views on keyboard.
MIT License
527 stars 64 forks source link

Add a TypeScript module definition #52

Closed jdmunro closed 4 years ago

jdmunro commented 4 years ago

Adds a TS module definition based on the documentation and prop types.

The type for KeyboardAwareTabBarComponent could be improved (the pass-through props will be untyped, essentially) but it should not cause any problems.

Perhaps the project will be written in TS one day, but this is a good part-way solution 😃

You'll need to make sure index.d.ts is included in the nom package when publishing.

jdmunro commented 4 years ago

Hey @ardaogulcan are you interested in merging these type definitions into the repo? If you'd prefer not to, I can submit them to DefinitelyTyped instead. Thanks!

ardaogulcan commented 4 years ago

Hi @jdmunro and @Roka20012 thanks for the PR. I am definetelly interested but I am on vacation with limited access. Will review and merge it in couple of days. Sorry for the delay.

jdmunro commented 4 years ago

@ardaogulcan No worries at all 😄 enjoy your vacation! 🏖️

ardaogulcan commented 4 years ago

@jdmunro thank you for the contribution. Type definitions should be available with v0.1.12. Sorry for the delay.

jdmunro commented 4 years ago

No worries at all - hope you had a nice vacation 😁🚀