search

ardata-fr / mschart

:bar_chart: mschart: office charts from R
https://ardata-fr.github.io/mschart
Other
131 stars 25 forks source link

Add support to set chart and plot area color and border #88

Closed trekonom closed 5 months ago

trekonom commented 1 year ago

The PR extends mschart by adding support to set the chart and plot area background fill and border.

The goal is to give users more options to create charts according to existing style guides, layouts or themes.

To this end I added four new theme arguments chart/plot_background and chart/plot_border.

As a use case and application of the new feature the PR also adds theme_ggplot2() providing a mschart theme inspired by ggplot2::theme_grey and chart_fill_ggplot2() to apply the default ggplot2 hue pal to a mschart. These functions are of course not needed. But I could imagine that having some built-in themes might be a nice feature.

Let me know what you think, if you have suggestions for improvements or ...

davidgohel commented 5 months ago

thank you @trekonom and sorry for the delay of a year...

trekonom commented 5 months ago

Great and thanks, David. Already guessed that your are way to busy. (; And as a ggplot2 user by heart that wasn't super important for me. :D But being able to create native Excel charts would make my life easier. Then my colleagues and clients can customise the charts themselves.