Fix aliased shared root fields

[kroupacz]

Description

This PR includes failing tests for issue #6613 - Aliased fields cannot be resolved in federated query Details can be found in https://github.com/ardatan/graphql-tools/issues/6613.

Fixes #6613

Test Environment:

• @graphql-tools/federation@2.2.19:
• NodeJS: node@20

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: fed7cea3ebb868d037d2115c3acef1e4529d3e39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

| Name | Type | | ----------------------------------- | ----- | | @graphql-tools/delegate | Minor | | @graphql-tools/federation | Patch | | @graphql-tools/batch-delegate | Patch | | @graphql-tools/links | Patch | | @graphql-tools/stitch | Patch | | @graphql-tools/stitching-directives | Patch | | @graphql-tools/wrap | Patch | | federation-benchmark | Patch | | @graphql-tools/url-loader | Patch | | @graphql-tools/executor-envelop | Patch | | @graphql-tools/prisma-loader | Patch | | @graphql-tools/executor-yoga | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kroupacz]

I am not sure whats wrong with imports from @apollo/gateway, but tests runs ok locally.

    TypeError: Cannot read properties of undefined (reading 'QUERY')

      2 | import { GraphQLSchema } from 'graphql';
      3 | import { createYoga } from 'graphql-yoga';
    > 4 | import { ApolloGateway, IntrospectAndCompose } from '@apollo/gateway';
        | ^

[kroupacz]

Hello @ardatan, here you can find failing tests for issues https://github.com/ardatan/graphql-tools/issues/6613 and https://github.com/ardatan/graphql-tools/issues/6614. Here https://github.com/ardatan/graphql-tools/pull/6620 is PR with fix for issue https://github.com/ardatan/graphql-tools/issues/6614.

Thank you in advance for your help and cooperation. Tomáš Kroupa

[ardatan]

Thanks for creating the PRs for the issues and fixes. They are really helpful. Do you think we could re-organize it in the following way?

• Move federation related tests under federation because it does not test the specific function so it'd better to keep federation related tests under federation.
• One PR for 6613 with the failing test for that specific issue
• One PR for 6614 with the test and the fix for that specific issue

So it'd be easier for us to distinguish the issues.

If you don't have time to do that, we can tackle it soon.

[ardatan]

Tests are passing somehow. Maybe you missed something in the tests.

[kroupacz]

@ardatan Yes, because this test tests that it really fails... 😄

  expect(res.data.errors).toMatchObject([
    {
      message: 'Cannot return null for non-nullable field TestNestedField.subgraph2.',
      path: ['testNestedField', 'testUserAlias'],
    },
  ]);

[ardatan]

Hahaha ok :D So it succeeds with a failure :P

[ardatan]

Thank you so much for the reproduction! I pushed the fix, I'll merge and release.