ardcore / chrome-better-bookmark

Chrome Extension that lets you easily add bookmarks to any category. Includes spotlight-like search with mouse/keyboard support.
https://chrome.google.com/webstore/detail/better-bookmark/pniopfmciclllcpockpkgceikipiibol
MIT License
63 stars 14 forks source link

version for Firefox #11

Open lpslp opened 4 years ago

lpslp commented 4 years ago

hi - is there a version of you great addon for Firefox?

fffx commented 3 years ago

@lpslp This repo didn't update for many years, so I have rewritten it in React, check this https://github.com/fffx/quick-bookmark. I didn't release a firefox version for now, because I haven't decided on default key binding, as cmd+B is a firefox shortcut.

The chrome version is here https://chrome.google.com/webstore/detail/quick-bookmark/bbjekmkfbdemdbfkckbakmmiceppjkdc/related

ardcore commented 3 years ago

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

fffx commented 3 years ago

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

thanks for your work, my project structure is based on web-extension-starter, and then I rewrite it by looking at your project。so the liscense is also copy from web-extension-starter。I'm sorry for not puting your notice in the lisence file. I will do it in a few days. But why I should put your liscense notice in package.json, manifest.json, since your project even don't have a package.json file? And Where do I put mutiple author in package.json or manifest.json?

ardcore commented 3 years ago

@fffx thanks for understanding. I think putting my name back into the LICENSE.md file and creating a separate file called AUTHORS.md listing us both (in separate lines) should be enough. :)

fffx commented 3 years ago

FYI: added https://github.com/fffx/quick-bookmark/blob/master/AUTHORS.md updated: https://github.com/fffx/quick-bookmark/blob/master/LICENCE