arddluma / cloudflare-pages-slack-notification

GitHub Action for CloudFlare Pages Slack notifications
https://ardd.cloud/setup-cloudflare-pages-slack-notifications
MIT License
19 stars 7 forks source link

Wait for a specific environment or branch #12

Open mwillema opened 1 year ago

mwillema commented 1 year ago

Hi there,

I'm wondering if it's possible to wait for the deployment of a specific branch or environment.

Let met explain:

I have the main branch (prod) and the staging branch (staging). CF Pages deploys automatically on every commit within those branches. In my GitHub workflow I'm waiting for the deployment to be done thx to this plugin. When the deploy is done from the main branch (so in production environment), I'm sending a notif to a "production" Slack channel. And when the deploy is done from the staging branch (so in "preview" environment wrt CF terminology), I'm sending a notif to a "staging" Slack channel.

The problem is, since the plugin waits for any build to be complete and the builds often run in parallel, the notifications are sometimes sent to the wrong Slack channel, ie prod notifications to the staging channel and vice versa.

If I could specify for which branch I want to wait for the build being complete, it would solve my issue. Alternatively it would also work if I can tell the plugin to wait for a build in the "production" env to be complete vs the "preview" env.

Is there a way to achieve this?

arddluma commented 1 year ago

Hi there,

I'm wondering if it's possible to wait for the deployment of a specific branch or environment.

Let met explain:

I have the main branch (prod) and the staging branch (staging). CF Pages deploys automatically on every commit within those branches. In my GitHub workflow I'm waiting for the deployment to be done thx to this plugin. When the deploy is done from the main branch (so in production environment), I'm sending a notif to a "production" Slack channel. And when the deploy is done from the staging branch (so in "preview" environment wrt CF terminology), I'm sending a notif to a "staging" Slack channel.

The problem is, since the plugin waits for any build to be complete and the builds often run in parallel, the notifications are sometimes sent to the wrong Slack channel, ie prod notifications to the staging channel and vice versa.

If I could specify for which branch I want to wait for the build being complete, it would solve my issue. Alternatively it would also work if I can tell the plugin to wait for a build in the "production" env to be complete vs the "preview" env.

Is there a way to achieve this?

Hello there, Thanks for creating this issue. Interesting! Haven't tried with parallel deployment... That seems very specific usecase. I will see what we can do hopefully this weekend / nearly next week