Rename `typenames` to `typeNames`

ardeois / graphql-codegen-typescript-mock-data

[GraphQL Codegen Plugin](https://github.com/dotansimha/graphql-code-generator) for building mock data based on the schema.

MIT License

134 stars 46 forks source link

Rename `typenames` to `typeNames` #105

Closed emab closed 1 year ago

emab commented 1 year ago

Fixes #104

This PR renames the typename config input to typeNames which matches the pattern used for other inputs.

This matches the naming conventions mentioned in the GQL Codegen docs here:

https://the-guild.dev/graphql/codegen/docs/config-reference/naming-convention#upper-case-enum-values

emab commented 1 year ago

Great! Yep I thought it might need a major bump.

Out of interest - is there a reason why it doesn't inherit directly from the root config namingConvention dictionary? I noticed this because I was spreading the options from there into my mock data config.

I'm guessing there are situations where you may need different conventions between plugins?

Happy holidays!

ardeois commented 1 year ago

Fixed in v3.0.0