ardeois / graphql-codegen-typescript-mock-data

[GraphQL Codegen Plugin](https://github.com/dotansimha/graphql-code-generator) for building mock data based on the schema.
MIT License
132 stars 47 forks source link

add support for useImplementingTypes #125

Closed maordaniel closed 1 year ago

maordaniel commented 1 year ago

Add support for useImplementingTypes GraphQL codegen configuration.

ardeois commented 1 year ago

Thanks for implementing this @maordaniel

I've got a few comments and the unit tests are failing

maordaniel commented 1 year ago

Thanks for implementing this @maordaniel

I've got a few comments and the unit tests are failing

Thank you for reviewing @ardeois The unit tests that fail are not related to changes in my pr..

ardeois commented 1 year ago

@maordaniel tests related to your code are now failing CleanShot 2023-03-23 at 15 36 27

maordaniel commented 1 year ago

@maordaniel tests related to your code are now failing CleanShot 2023-03-23 at 15 36 27

Fixed and i added one more test @ardeois

maordaniel commented 1 year ago

Sorry for the late review, I got quite busy these last few days. I tried to do an in depth review and found potential issues. Let me know what you think

Thanks again for the help !

Hi Ardeois, hope you are well. i've fixed the issues you mentioned. no problem, thanks 🙏 @ardeois

maordaniel commented 1 year ago

Looks good ! thanks for the updates

Thanks a lot, Really appreciate that ! @ardeois

I updated readme file and the snapshot for the test, pls approve this again.

maordaniel commented 1 year ago

Hi @ardeois , When are you going to merge it?

Thanks

ardeois commented 1 year ago

Hi @ardeois , When are you going to merge it?

Thanks

Sorry about that @maordaniel I forgot It's merged !

maordaniel commented 1 year ago

Thanks a lot! 🙏🏻 @ardeois