Closed maordaniel closed 1 year ago
Thanks for implementing this @maordaniel
I've got a few comments and the unit tests are failing
Thanks for implementing this @maordaniel
I've got a few comments and the unit tests are failing
Thank you for reviewing @ardeois The unit tests that fail are not related to changes in my pr..
@maordaniel tests related to your code are now failing
@maordaniel tests related to your code are now failing
Fixed and i added one more test @ardeois
Sorry for the late review, I got quite busy these last few days. I tried to do an in depth review and found potential issues. Let me know what you think
Thanks again for the help !
Hi Ardeois, hope you are well. i've fixed the issues you mentioned. no problem, thanks 🙏 @ardeois
Looks good ! thanks for the updates
Thanks a lot, Really appreciate that ! @ardeois
I updated readme file and the snapshot for the test, pls approve this again.
Hi @ardeois , When are you going to merge it?
Thanks
Hi @ardeois , When are you going to merge it?
Thanks
Sorry about that @maordaniel I forgot It's merged !
Thanks a lot! 🙏🏻 @ardeois
Add support for useImplementingTypes GraphQL codegen configuration.