search

ardeora / solid-toast

Customizable Toast Notifications for SolidJS
https://www.solid-toast.com
MIT License
831 stars 26 forks source link

Lazy Loading #19

Open goenning opened 2 years ago

goenning commented 2 years ago

Is it possible to lazy load this package?

My use case is that most users will never see a toast, so I don’t want them to pay the price of extra JS unnecessarily

it’s pretty easy to lazy load the “toast” object, but the problem is the Toaster container. I’ll try do It by dynamically attaching it to the DOM on first use (maybe using Solid Portal?), but in case someone already solved this, please share 😊

ardeora commented 2 years ago

I apologise I haven't had time to look at this. Are you aware of any other UI libraries leveraging lazy loading? I would love to take a look and see if we can get it working with Solid Toast

goenning commented 2 years ago

React Toastify: https://github.com/fkhadra/react-toastify/issues/276

I did that in 2018, so things might have changed/improved since

ardeora commented 2 years ago

Ooh awesome! This is a really helpful example. I'll take a look and follow back with ideas.