ardevd / jlrpy

Python library for interacting with the JLR Remote Car API
MIT License
84 stars 29 forks source link

Privacy #113

Closed sjpbailey closed 6 months ago

sjpbailey commented 9 months ago

Hello Ardevd,

I enabled Privacy mode and cannot get it disabled? What am i doing wrong? Fantastic Python interface! Cheers!

def privacy(self, command):
        c = jlrpy.Connection(self.email, self.password)
        v = c.vehicles[0]
        mode = int(float(command.get('value')))
        if mode == 1:
            v.enable_privacy_mode(self.pin)
            self.setDriver('GV23', 0)
            time.sleep(5)
            self.reportDrivers()
        elif mode == 0:
            v.disable_privacy_mode(self.pin)
            self.setDriver('GV23', 1)
            time.sleep(5)
            self.reportDrivers()
        else:
            logging.error('Unknown command for Privacy Mode {}'.format(command))

When you call trips with python they all show up.

for i in v.get_trips()["trips"]:#[size-4:size-3]:
    #print(i)
    #print('/n')
    #print(i['id'])
    print(i['routeDetails'])
    print(i['tripDetails']['startPosition']['address'])
    print(i['tripDetails']['endPosition']['address'])
    #print('\n')
    #print(int(i['tripDetails']['startOdometer']*0.00062137))
    #print(int(i['tripDetails']['endOdometer']*0.00062137))
    #print('\n')
    speed = int(i['tripDetails']['averageSpeed'])
    speed = speed
    print(speed)    

Open the Land Rover Remote app and trips do stop at November 17, 2023. I guess it still logs trips no matter what Privacy mode is in, seems to just stop app logins. Enable seems to works for the Remote Phone App however i does not re-enable and start to log there again. I guess nothing is private anymore.

Thank you for your time, Steve

ardevd commented 9 months ago

What happens if you try to disable the privacy mode? Whats the response?

v.disable_privacy_mode(self.pin)

sjpbailey commented 9 months ago

Disable Privacy response: DATA: {'token': '7a4d1074-abe4-4d3b-b1c7-16151f7f71cb', 'serviceCommand': 'privacySwitch_off', 'startTime': None, 'endTime': None} METHOD: POST 

 I see today the phone app appearance has changed for the new year. The Problem: Trips on the Phone app are disabled since November 17, 2023 as its last date. So it has been disabled for quite some time, "phone app only".  I will check when the wife returns if it started to record again on the phone app now that it is enable privacy. It shows privacy switch on with a reenable.

DATA Response: {'token': '7f4d572a-5cfd-45d2-94b1-3967e75b5d40', 'serviceCommand': 'privacySwitch_on', 'startTime': None, 'endTime': None} METHOD: POSTCall v.get_trips()

Call trips with Python and they're all there.

Privacy doesn't shut all trips off evidently?

On Jan 2, 2024, at 1:02 AM,

ardevd @.***> wrote: What happens if you try to disable the privacy mode? Whats the response? v.disable_privacy_mode(self.pin)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

sjpbailey commented 9 months ago

Ardevd, Did you see my last email response? I checked today after my Wife drove to work unfortunately the phone app is still showing up to November 17, 2023 with privacy re-enabled. Also as i mentioned call trips with Python and they are all there. So Privacy disables the phone app log as it keeps logging in the background. Re-enable doesn't work to restart the record on the phone app. Phone app looks to be updated. Thank You for Your Time, Bailey

ardevd commented 9 months ago

Have you tried disabling Privacy mode from inside the vehicle infotainment directly or using the official Jaguar InControl mobile app?

sjpbailey commented 9 months ago

Not yet i definitely will tomorrow.Then i will test calls again and get back to you.Thank You for Your timeOn Jan 4, 2024, at 10:10 PM, ardevd @.***> wrote: Have you tried disabling Privacy mode from inside the vehicle infotainment directly?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

ardevd commented 6 months ago

Closing this due to lack of response.

sjpbailey commented 6 months ago

Go ahead close it, i will re-test it after engine start is fixed. Do you have a Python Curl for engine start? Json parameters also? I will test it with Python.