search

ardevd / jlrpy

Python library for interacting with the JLR Remote Car API
MIT License
85 stars 28 forks source link

Update user info request #121

Closed msp1974 closed 3 months ago

msp1974 commented 4 months ago

Since the update to the JLR incontrol rest api service, the user info function no longer works. This corrects that by making the url correct to this update.

ardevd commented 4 months ago

can you provide an example of how the previous implementation doesnt work?

c.get_user_info() works fine for me currently.

msp1974 commented 4 months ago

It was giving a 404 error. Maybe it has changed again. Either way, the url for the _login_user function in jlrpy is the one the JLR app uses for getting user info.

If it is working now, maybe it doesn't need to change then.

ardevd commented 4 months ago

Feel free to test yourself, but the current version works for me, both here and through WattCat

ardevd commented 3 months ago

Just tried this again and indeed it does show the 404 error. Your merge request fixes it! Thank you

ardevd commented 3 months ago

This fixes #127