refactor: get_trips - define the time frame

ardevd / jlrpy

Python library for interacting with the JLR Remote Car API

MIT License

84 stars 29 forks source link

refactor: get_trips - define the time frame #128

Closed shegnauer closed 6 months ago

shegnauer commented 6 months ago

Start / stop dates are strings in ISO 8601 format. If no timezone is given, the local timezone is used if available. If not, UTC is assumed. The dates + times are then converted to UTC for simplicity. CAVE: The search on the JLR servers is recent-to-old.

If no start and/or stop dates are given, the behaviour of get_trips is unchanged wrt the function it replaces.

This PR solves #119

ardevd commented 6 months ago

LGTM! Thank you for the contribution!