search

ardevd / jlrpy

Python library for interacting with the JLR Remote Car API
MIT License
85 stars 28 forks source link

allow for long trips #89

Closed azryn42 closed 3 years ago

azryn42 commented 3 years ago

added ability to select additional sections of waypoints in a trip exceeding 1000 points

ardevd commented 3 years ago

Thank you for the contribution. Nice find. Any reason why you would want the default to be 1 and not 0? The official mobile apps use 0.

azryn42 commented 3 years ago

Thank you for the contribution. Nice find. Any reason why you would want the default to be 1 and not 0? The official mobile apps use 0.

You bet, thanks for the interface. Saved me a ton of time! Re: default, jlr seem to return page 0 and 1 with the same result set; so if you iterate the pages baselined at 0 you'll end up with a whole page of duplicates at page 1.