search

ardite / ardite-core

Core library for Ardite services.
MIT License
3 stars 1 forks source link

fix: clippy warnings #20

Closed svmnotn closed 8 years ago

svmnotn commented 8 years ago

I just installed cargo clippy and was looking to see where to try it.

So I ran cargo clippy on this and fixed all the warnings.

I would like some comments on into_ vs as_

svmnotn commented 8 years ago

Just as a note, atom find & replace did 90% of the work :blush:

svmnotn commented 8 years ago

Ok so, as_* is a better replacement for to_* than into_*? Nope... as_* has the same issue.

calebmer commented 8 years ago

I prefer using impl Into<_> for the to_schema/to_definition scenario, and changing self to &self for to_json.

calebmer commented 8 years ago

Oh shoot, I forgot about the error, that complicates Into. It's fine for now because eventually id like to move away from this mode of deserialization.

Looks good to merge 👍