search

ardite / ardite-core

Core library for Ardite services.
MIT License
3 stars 1 forks source link

Refactor driver #5

Closed calebmer closed 8 years ago

calebmer commented 8 years ago

Some initial thoughts. The driver is still very shallow though. Only works on a collection level…

calebmer commented 8 years ago

Not ready to be merged.

svmnotn commented 8 years ago

if you could add the rustfmt, and .gitignore changes from #3 into this, since it will probably get merged first, that would be nice.

Also don't forget &self

calebmer commented 8 years ago

Just commit those to the develop branch directly as a chore type.

svmnotn commented 8 years ago

done, updating #3 to merge nicely with develop was a chore.... I never want to do that again...

calebmer commented 8 years ago

Ready for review.

svmnotn commented 8 years ago

Ok, other than the unimplemented fn in Error, it should be ok to merge