search

ardittristan / 5eSheet-resourcesPlus

A module that allows you to add more resources to 5e character sheets
GNU General Public License v3.0
9 stars 5 forks source link

[BUG] Resource values not saving #27

Closed Orionox closed 1 year ago

Orionox commented 1 year ago

Describe the bug Closing a character sheet resets the values entered into the extended resource values since the most recent 5e update.

To Reproduce Open character sheet, fill out values for resource, close character sheet, and resource values for resource 4+ will be empty.

Setup:

krbz999 commented 1 year ago

Note for the dev: The additional resources added by this module should be saved in the actor flags under the module scope, rather than attempting to inject new values into the System data, which is no longer possible in dnd5e as of v2.1.0 since it now has a SystemDataModel.

Wraithlord2015 commented 1 year ago

Is this an issue with the module or the 5e core update? Just want to make sure it's reported in the correct place to fix it if possible.

Orionox commented 1 year ago

This is only for resources added by this module.

On Thu, Jan 19, 2023, 18:14 Cyanide @.***> wrote:

Is this an issue with the module or the 5e core update? Just want to make sure it's reported in the correct place to fix it if possible.

— Reply to this email directly, view it on GitHub https://github.com/ardittristan/5eSheet-resourcesPlus/issues/27#issuecomment-1397809616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZBNPT6ONLVTKFBDUDUNJDWTHRILANCNFSM6AAAAAAT3JJRLE . You are receiving this because you authored the thread.Message ID: @.***>

tprussak commented 1 year ago

Is this an issue with the module or the 5e core update? Just want to make sure it's reported in the correct place to fix it if possible.

It is an issue with the module, but it is caused by the 5e core updating the way it stores data. The module needs to be updated to support the new data structures in the 5e core.

Wraithlord2015 commented 1 year ago

Is this an issue with the module or the 5e core update? Just want to make sure it's reported in the correct place to fix it if possible.

It is an issue with the module, but it is caused by the 5e core updating the way it stores data. The module needs to be updated to support the new data structures in the 5e core.

Tks for a quick reply! I rely on this heavily - so hope it's fixed quickly.

ardittristan commented 1 year ago

I'm looking at it!