search

ardittristan / HearthstoneQuestOverlay

Overlay that shows your current quests for Hearthstone Deck Tracker
MIT License
8 stars 0 forks source link

Same issue after this patch #13

Closed chWolfgang closed 2 years ago

chWolfgang commented 2 years ago

Greetings, Unfortunately, I seem to have the same issue as last time after this patch. The overlay is on the screen, but when you try to use it you get nothing.

I hope this a quick fix, I love this add on.

Thanks for your time!!

s3ofor3v3r commented 2 years ago

Same here ... :'(

ardittristan commented 2 years ago

For whatever reason HearthMirror does not like the new reward system layout, so it'll need some more time to be fixed.

ardittristan commented 2 years ago

I currently don't have enough time to fix it sadly, tried for 3 hours. A lot of internal structure around quests changed.

sebastientromp commented 2 years ago

In case that helps, this is the commit that I did for Firestone: https://github.com/Zero-to-Heroes/unity-spy-.net4.5/commit/0bbff22ab5799b97b178e054f0d8ff3d3fd51a56

It should give you more or less the info on how to handle the new structure in memory.

ardittristan commented 2 years ago

In case that helps, this is the commit that I did for Firestone: Zero-to-Heroes/unity-spy-.net4.5@0bbff22

It should give you more or less the info on how to handle the new structure in memory.

The issue I'm having is that hearthmirror breaks on m_rewardTrackEntries and the entries property returns nonsensical data (seems like some error in reading). I don't know hearthmirror well enough to fix this. And since they already have some reward track code in hearthmirror which isn't updated to the new version yet I hope they'll fix it and then I can use it as well.

ardittristan commented 2 years ago

I won't have time to code until Wednesday, so I'll look at it again on Wednesday!

sebastientromp commented 2 years ago

Ah got it, in that case there's nothing I can do to help, but they should indeed fix this pretty quickly. Good luck!

ardittristan commented 2 years ago

I have it working now by manually parsing the object instead of letting the autoparser do it. Though the quest image assetbundle also changed, so I'll have to fix that as well.

ardittristan commented 2 years ago

Still haven't found the assetbundle that contains the quest icons. I can continue fixing on Saturday.

ardittristan commented 2 years ago

Nvm, had 2 hours free today. Semi fix is pushed, but still needs some work (though technically it fully works again, just a bit ugly since it also includes battlegrounds quests)

chWolfgang commented 2 years ago

It does seem to be working again!! TYVM

ardittristan commented 2 years ago

Fully closed with 1.5.0