ardittristan / VTTColorSettings

adds color picker as settings option in Foundry VTT
MIT License
8 stars 9 forks source link

Colorpicker setting still displays with config: false set #7

Closed Norc closed 4 years ago

Norc commented 4 years ago

I'm trying to move my Color Picker settings to a separate HTML settingsMenu window, but when I list config:false it still displays in the standard Foundry settings... the two Number settings were hidden properly with the same line added.

Example:

        //                                     module        key             options
        new window.Ardittristan.ColorSetting("custom-hotbar", "chbPrimaryColor", {
            name: "customHotbar.settings.chbPrimaryColor.name",      // The name of the setting in the settings menu
            hint: "customHotbar.settings.chbPrimaryColor.nameHint",   // A description of the registered setting and its behavior
            label: "Color Picker",         // The text label used in the button
            restricted: false,             // Restrict this setting to gamemaster only?
            config: false,                 // Disable display on the standard Foundry settings menu
            defaultColor: "#0000FF80",     // The default color of the setting
            scope: "client",               // The scope of the setting
            config: false,                 // Disable display on the standard Foundry settings menu
            onChange: (value) => {ui.customHotbar.render();}        // A callback function which triggers when the setting is changed
        })

This still displays in the settings menu, and I don't think it should:

Foundry 0.6.5, lib-color-settings 2.2.2

ardittristan commented 4 years ago

The html version does not use the ColorSetting object, it just puts the color code in a text field. That being said, there were a few bugs with the html that are fixed now. Thanks for the help @Norc!