search

ardittristan / VTTNPCGen

MIT License
8 stars 13 forks source link

Own set of names 2nd try :) (low prio) #23

Closed radkonf closed 3 years ago

radkonf commented 3 years ago

hi I've tried your code: { "First": { "Male": { "All": [ "Firstname1", "Firstname2" ] }, "Female": { "All": [ "Firstname1", "Firstname2" ] } }, "Last": { "All": [ "Lastname1", "Lastname2" ] } }

image image

Again with male/female I get no Firstname With non-binary I do get a Firstname (just a side note I changed the to FIrstnameFemale / FIrstnameMale - the non-binary selects from both I still don't get it :)

ardittristan commented 3 years ago

Am able to replicate now, will look into it!

ardittristan commented 3 years ago

Turns out there was a capitalization mistake, is fixed, though only on the foundry 0.8 version. If you want to fix it in the 0.7 version you should replace all on this line with All https://github.com/ardittristan/VTTNPCGen/blob/0.5.0_fix/modules/applications/NPCGenerator.js#L963

radkonf commented 3 years ago

Just realized I can't change it, I#m running on the forge. Wait I could install it in my local file - change it and upload it as a cutommodule or I'll wait until 8.0 shouldn't be that long

ardittristan commented 3 years ago

I pushed it to the 0.5 static manifest version. so if you reinstall that version it should work! (manifest url is at the top of readme)

radkonf commented 3 years ago

Awsome works like a charm, didn#t expected that you do that. Could have waited so even more thanks: )