codepathreview
commented
8 years ago :+1: Project looks good, glad you were able to finish all required stories
- Nice to see you used the ViewPager to properly setup the tabs!
- Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have a lot of code duplication.
- ProfileActivity should have also been able to use a timeline fragment if code above was architected properly. Similarly you wouldn't have to write so many adapters.
- Consider adding progress bars to your app whenever a network request goes out
- In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide
We have provided a detailed Twitter Redux Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
https://github.com/ardok/codepath/pull/10
Path: https://github.com/ardok/codepath/tree/master/TwitterClient (README already updated at the bottom part)
/cc @codepathreview @codepath