search

ardoq / ardoq-java-client

Java Wrapper for the Ardoq Rest-API
Eclipse Public License 1.0
2 stars 4 forks source link

fixed possible null fields #25

Open leolivier opened 3 years ago

leolivier commented 3 years ago

Hi @kristianhelgesen STill my issue on updating references. I had to change the ReferenceAdapter to be able to update references which don't have fields. All y components have specifi fields so I didn't fall in the same situation for components but as far as I can see, the same problem exists... I noticed the same kind of problem if for instance the description is null. I don't know if it's possible under normal conditions but we migrated a lot od applications into Ardoq using the Excel importer and for all applications and references which didn't have an explicit description, the description field seems to be null. I fixed that in ly own code by setting an empty string but it should also probably be checked.

leolivier commented 3 years ago

Finally, I don't know if this PR is right or not. I discovered this morning that due to this change, I broke all the references I changed by removing all the fields they contained! 👎 The issue is that when I received the references from the get component, they didn't contain the fields 👎 So I updated them without the fields And as I cannot go back, I broke >1000 references that I will to reimport I don't know how 👎 👎 👎 A bit angry...

kristianhelgesen commented 3 years ago

Hi. Sorry to hear this. I see you have a request open with our main support channel. You'll get faster response times following up there.