Add navigation drawer

[ardovic]

A simple navigation drawer for future functionality. Currently, we plan to add authentication, profile (name-email-avatar) for preferences saving, forecast types, credits, notification options and general customization settings buttons.

P.S.: The list of functionality is not the part this issue.

[nsvrohit]

I would like to work on this issue. Please assign me to it.

[ardovic]

You don't appear in the list for assignees at the moment. Consider yourself being assigned.

Looking forward for your solution in a pull request soon. If you never did a pull request before, make sure to read the README.md file of the project — it contains a short guide on how you can contribute.

[nsvrohit]

I'm pretty much done except for this one GLARING error. It says - Cannot resolve symbol 'R' I've gone through all the forums but none of their suggestions helped. Do you have any idea on how to approach this?

[ardovic]

It might be because you didn't install the Lombok plugin. Follow instructions here: https://projectlombok.org/setup/android

After, clear cache and invalidate, restart Android Studio and rebuild the project.

[nsvrohit]

Didn't help. Any other ideas?

[ardovic]

Can you commit your changes and push them to your fork, I'll take a look.

[nsvrohit]

Was unable to commit but I have uploaded the changed files here; https://github.com/BrahM0s/Weather-App-with-Nav Please have a look and let me know where I have gone wrong.

[nsvrohit]

I screwed up the merge so please check the link provided and not the fork.

[ardovic]

I've checked your project, the problem with Cannot resolve symbol 'R' can be solved by adding android.enableAapt2=true line to gradle.properties file. After, just sync the project and this error will be gone.

[nsvrohit]

Hey! It took a while but I fixed it. I was able to put in the navigation drawer. Unfortunately, very stupidly I deleted the fork. How do I make a pull request now? Here's the link to the final fix: https://github.com/BrahM0s/Open-Weather-Android

[ardovic]

Hi, unfortunately the only way to make a pull request is to have a fork of the original project. You'll have to make another fork and copy/paste your changes from your current project, then make a pull request as usual.

[nsvrohit]

Made the pull request. Do check.

[ardovic]

Great. I merged it to current project. Very nice job! Since you're a contributor, I invite you to our Android OSC (Open Source Community) organisation as a member. please accept at: https://github.com/android-osc

[ardovic]

Regarding the navigation drawer. It's good, but next we need to bring it forward (above the toolbar). Also, an icon should be added to the left side of the toolbar, so that it can be used as a button to open navigation drawer. Take a look at this example:

[nsvrohit]

Hey sorry for going AWOL. I was on a long weekend. I'm just about done with the necessary changes. You can expect a pull request soon.

[nsvrohit]

Fixed that issue. Please check the pull request.

[kapilajayant]

A simple navigation drawer for future functionality. Currently, we plan to add authentication, profile (name-email-avatar) for preferences saving, forecast types, credits, notification options and general customization settings buttons.

P.S.: The list of functionality is not the part this issue.

Hi, I think there is plenty much more work to do on the nav bar as it is not working. I cloned the dev branch and ran it on my device, what I saw was that the action bar is overlapping the nav bar and the contents of nav bar are not accessible. I would like to work on that issue.

[ardovic]

@kapilajayant Hi Jayant! I'm very glad you came along. Indeed, you can start working on the issue, it would be superb if you'd find out and solve the NavDrawer issue. If you need help let me know, I really really want to restart active work on this project and make it more beginner-friendly and useful.

[kapilajayant]

Ok, I'll start working on it. Can you help me find the latest build of the app so that I can see all the latest updates? Also, i was not able to open the project when I cloned the master branch. what's up with that?

[ardovic]

@kapilajayant I just downloaded the project and ran it from scratch, everything seems to work just fine.

[ardovic]

@kapilajayant I have updated dependencies and migrated to Android X, please pull changes to your project ASAP, so that it works and will merge in the future without conflicts.

[kapilajayant]

Ok I'll start fixing the navigation bar and action bar issue

[DjamelALI]

Hello everyone,

I've launched the application, there's no Navigation Drawer ! (the NavigationDrawer.java class exists but is not displayed in the GUI). Can you assign me this task, please ?

Thank you for your attention !