search

ardovic / Open-Source-Android-Weather-App

☔️ Open source android weather app. See "Issues" tab for current tasks queue. Tasks suitable for beginners are labeled with green "beginner friendly" tags.
https://www.ardovic.com
MIT License
104 stars 81 forks source link

Landscape branch #63

Closed leila94 closed 3 years ago

leila94 commented 3 years ago

Description

Hi Ardovic,

Here are the changes: Landscape mode is disabled on phones and only works on tablets. Main screen elements are rearranged in landscape. Data will not be missed after rotation.

I tested the app on a tablet and phone emulator and a real phone device. works perfect.

note: I didn't change the navigation drawer. Do you want it to be redesigned or set as always-open?

ardovic commented 3 years ago

The nav drawer could be redesigned a little, not critical though. You can propose a PR for that. Thank you, good work!