search

ardriveapp / ardrive-web

The ArDrive App allows a user to log in to securely view, upload and manage their ArDrive files with their browser or mobile phone.
https://app.ardrive.io
Apache License 2.0
59 stars 19 forks source link

PE-6802: feat(timestamps) #1872

Closed thiagocarvalhodev closed 1 month ago

thiagocarvalhodev commented 1 month ago

--- Releases --- Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/1bedgacnqm31g

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 79e58cb):

https://ardrive-web--pr1872-pe-6802-timestamps-awg70iti.web.app

(expires Thu, 03 Oct 2024 19:12:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

kunstmusik commented 1 month ago

Did a search of the branch code and found yMMDateFormatter is still used in a few places and wonder if they need to be updated or if it is fine to leave as-is. If you could confirm @thiagocarvalhodev that'd be great.

image
thiagocarvalhodev commented 1 month ago

Did a search of the branch code and found yMMDateFormatter is still used in a few places and wonder if they need to be updated or if it is fine to leave as-is. If you could confirm @thiagocarvalhodev that'd be great.

image

Good catch, @kunstmusik!!

One of the files was not being used anywhere. I removed. There are just two places now on the item tile file. We will show on the drive explorer just the date instead of the timestamp, if the user hovers above the date we show the new formatted date