Open jdeeny opened 5 years ago
So I think what is happening is that CPU doesn't have AVX2 instructions, and the way the tests are structured right now, assumes they are being run on a cpu that supports all of the instruction sets. Definitely worth fixing. I welcome PRs to address it if you want to have a go, otherwise I'll get to it probably in a few days.
I was looking at this, thinking I could add a fn is_supported() -> bool
to the Simd
trait and put is_x86_feature_detected!("xxx")
in each one. Then make a consistency test that tries every type that is supported against every other type.
With nostd, I can't use that macro. Should I always send true? false? Should the return be something other than a bool.
Or maybe I've headed off in the wrong direction. Let me know what you think.
The tests are failing for me too. Anything new ?
@jdeeny : can you check if this PR / branch solves your issue. If it does, can you do an approval?
When I run the test suite on an AMD Phenom 9850 (tested inside a virtual machine only), the consistency test fails:
If I run in gdb I get this information about the crash:
I am using code from the github repo, commit 604d9e55fb036c6108ea0624c9c887bc28dbb1b6