arduino-cmake / Arduino-CMake-NG

CMake-Based framework for Arduino platforms
MIT License
138 stars 39 forks source link

Add tests for Fedora and Arch builds #83

Closed TellowKrinkle closed 5 years ago

TellowKrinkle commented 5 years ago

Docker-based unit tests for the new functionality added in #81

TellowKrinkle commented 5 years ago

The preferences file was to direct the AUTO_SET_SKETCHBOOK_PATH functionality. I could specify the sketchbook path directly instead though. Do you think that would be a better idea?

MrPointer commented 5 years ago

The preferences file was to direct the AUTO_SET_SKETCHBOOK_PATH functionality. I could specify the sketchbook path directly instead though. Do you think that would be a better idea?

Yes, I think so. It just seems a bit more natural to set a single env var manually/directly instead of passing a whole file, which affects other things as well. At least, that is how I would do it in our other CI builds.