arduino-libraries / ArduinoBLE

ArduinoBLE library for Arduino
GNU Lesser General Public License v2.1
310 stars 205 forks source link

BLE.scan will not work after a BLE.scanFor[Uuid|Name|Address], even after a BLE.stopScan #350

Open andrewchilds opened 8 months ago

andrewchilds commented 8 months ago

Hello! Thank you for building and maintaining this library. Here is a simple test case with a buggy path, and a separate workaround using the existing library code:

#include <ArduinoBLE.h>

#define SERVICE_UUID "MY-SERVICE-UUID"

unsigned long scanStart;
bool fallbackToFullScan = false;

void setup() {
  Serial.begin(9600);
  delay(1000); // Wait for serial

  if (!BLE.begin()) {
    Serial.println("Starting BLE failed!");
    while (1);
  }

  Serial.println("Scanning by Service UUID...");
  BLE.scanForUuid(SERVICE_UUID);
  scanStart = millis();
}

void notWorkingScan() {
  BLE.stopScan();
  delay(1000);
  // This scan will not work - it will continue to behave like BLE.scanForUuid(SERVICE_UUID)
  BLE.scan();
}

void workingScan() {
  // This will reset _scanNameFilter, _scanUuidFilter, and _scanAddressFilter to ""
  BLE.scanForUuid("");
  BLE.stopScan();
  delay(1000);
  // This scan will now work
  BLE.scan();
}

void loop() {
  BLEDevice peripheral = BLE.available();

  if (peripheral) {
    Serial.println("Peripheral found!");
    BLE.stopScan();
  }

  // Wait 5 seconds to connect, then fall back to a regular scan.
  if (!fallbackToFullScan && millis() - scanStart > 5000) {
    scanStart = millis();
    Serial.println("Falling back to full scan...");
    fallbackToFullScan = true;
    // notWorkingScan();
    workingScan();
  }
}

From looking at GAP.cpp, it seems that _scanNameFilter, _scanUuidFilter, and _scanAddressFilter are not unset during a stopScan, so a BLE.scan will continue to use the previous filters (since BLE.available is where the filters are used). You can unset the filters by passing an empty string to scanForUuid(), scanForName(), or scanForAddress(), at which point the subsequent BLE.scan will start working.