search

arduino-libraries / ArduinoBearSSL

Port of BearSSL to Arduino
MIT License
86 stars 49 forks source link

src/BearSSLClient.cpp: fix _ecSign #36

Closed ffontaine closed 4 years ago

ffontaine commented 4 years ago

The client can specify its own _ecSign function since commit 996778e73d22093526b1b7126cf7bfc2499158b5 as well as its own certificate since commit 874c6b0c38ae2ad34a3388710961411e3a3aed5a. The goal was to allow the user to use ArduinoBearSSL without the ECCX08 (for example with an (e)SIM applet compliant to the new GSMA IoT SAFE standard).

However, these two functions don't work because br_ssl_client_set_single_ec is not called if _ecKey.xlen is set to 0 so fix this latest issue

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

luigigubello commented 4 years ago

Hi @ffontaine, thank you for your contribution! The PR is ok for me, but seeing @aentinger's comment in the PR #36 I would like to be sure this change cannot create any conflict in ArduinoIoTCloud library. @aentinger, can you confirm this?

luigigubello commented 4 years ago

Hi @ffontaine, thank you for your contribution, I have merged the commit :)