Define SHA1 function as SHA1_ to make it a "private" symbol when building on Arduino

arduino-libraries / ArduinoECCX08

78 stars 49 forks source link

Define SHA1 function as SHA1_ to make it a "private" symbol when building on Arduino #17

Closed sandeepmistry closed 5 years ago

sandeepmistry commented 5 years ago

This avoids having a global SHA1 symbol so another library can define it.

Note: the SHA1 code is needed for the self signed certificate sketch because Azure IoT Hub needs a SHA1.

facchinm commented 5 years ago

I'm not a huge fan of code duplication :slightly_smiling_face: Could a macro trick work better somehow? Still thinking about a clever one though :stuck_out_tongue:

sandeepmistry commented 5 years ago

@facchinm good feedback! I've pushed some changes, what do you think now?

If it looks good I can squash my changes and force push.

facchinm commented 5 years ago

LGTM!